This PR makes progress on getodk/central#589. It makes a couple of changes to how the modal appears during the upload request:
The content of the modal is grayed out during the request.
A spinner is not shown in the "Append data" button during the request.
This is consistent with the release criteria, which don't show a spinner in the button. It makes sense to me that there isn't a spinner in the button, since the pop-up has a more visible spinner.
What has been done to verify that this works as intended?
New tests. Currently, the modal doesn't show any content during the request, so it's not easy to verify the first change manually.
Before submitting this PR, please make sure you have:
[x] run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
[x] verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced
This PR makes progress on getodk/central#589. It makes a couple of changes to how the modal appears during the upload request:
What has been done to verify that this works as intended?
New tests. Currently, the modal doesn't show any content during the request, so it's not easy to verify the first change manually.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes