Closed matthew-white closed 4 months ago
I've pushed a commit that resolves some, but not all of the comments above. Most of the comments that I didn't resolve are a bit fiddly. I don't think they need to be resolved before regression testing begins. I'm going to go ahead and merge this PR, then follow up with another PR later to resolve the remaining comments. These are the comments that are currently remaining:
Closes getodk/central#589.
What has been done to verify that this works as intended?
This PR includes some changes to tests, but mostly I've just been doing manual testing locally. The QA team will also be taking a look at this PR. I'll be adding more tests as part of #979.
Before submitting this PR, please make sure you have:
npm run test
andnpm run lint
and confirmed all checks still pass OR confirm CircleCI build passes