getodk / central-frontend

Vue.js based frontend for ODK Central
https://docs.getodk.org/central-intro/
Apache License 2.0
32 stars 56 forks source link

Fix geopoint column width in submission #975

Closed ktuite closed 3 months ago

ktuite commented 3 months ago

Closes https://github.com/getodk/central/issues/635

Makes sure geopoint column has room to grow to show entire value. The value is often very close to 250px but this ensures that it can use a bit more if it needs to.

Screenshot 2024-04-22 at 5 07 37 PM

The problem before was a max-width: 500px CSS rule that wasn't getting applied because of change in a different file (submissions/table.vue) that was canceling out the CSS. Using the extra class selector (.table-freeze-scrolling) from the other file worked to have this greater max width go into effect again, and provide a clue to CSS effects from this other file.

This PR mentions

We don't add tooltips for field types whose text shouldn't be truncated: int, decimal, date, time, dateTime, and geopoint. (geopoint columns are styled to be up to twice as wide as others.)

What has been done to verify that this works as intended?

Tried it!

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to user documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have: