getodk / central-frontend

Vue.js based frontend for ODK Central
https://docs.getodk.org/central-intro/
Apache License 2.0
32 stars 56 forks source link

Do not show warning if CSV delimiter is not a comma #978

Closed matthew-white closed 3 months ago

matthew-white commented 3 months ago

This PR changes what happens if something other than a comma is used as the CSV delimiter. A non-comma delimiter will continue to be shown in EntityHeaderErrors if the header row is invalid. However, it will not be returned in the warnings from parseCSV() or shown in EntityUploadWarnings.

What has been done to verify that this works as intended?

I updated tests to match the new behavior.

Before submitting this PR, please make sure you have:

matthew-white commented 3 months ago

Ah yes, that's a test that was missing. There are still a number of those, and I've filed the issue #979 about that. But this is probably as good a time as any to add that missing test. I've just pushed a commit that tests that the EntityUploadHeaderErrors component use the delimiter from the CSV file.