search

getodk / central

ODK Central is a server that is easy to use, very fast, and stuffed with features that make data collection easier. Contribute and make the world a better place! ✨🗄✨
https://docs.getodk.org/central-intro/
Apache License 2.0
121 stars 145 forks source link

2 different ways of presenting edited empty values in the Entity detail and the Submission detail page #628

Open dbemke opened 2 months ago

dbemke commented 2 months ago

Problem description

There are 2 different ways of presenting empty values after editing them in the Entity detail page and the Submission detail page.

Steps to reproduce the problem

  1. Create 2 submissions in a form creating entities and leave some properties empty.
  2. Go to Submissions and edit the empty values.
  3. Go to Entities and edit the values.

    Scree

    submissionDetailEdit nshot entityDetailEditProper

Expected behavior

Empty values should be presented in the same way across different pages.

Central version shown in version.txt

https://staging.getodk.cloud/#/ versions: f0b2a90bce34fc13b0df4affd8b3158d57bcf904 (v2023.5.1-5-gf0b2a90) +2bb17a501416814bbd987ddc953abc5b0c40c58a client (v2023.5.0-43-g2bb17a50) +267e0ad7806057fc82894f58bea680627f1de5cd server (v2023.5.0-49-g267e0ad7) https://test.getodk.cloud/ versions: 645a8061b8df3644584cefc036d751c6115fcbec (v2023.5.1-3-g645a806) +5c93766eb558c113a6389f7d035d3bde3fe2261f client (v2023.5.0-47-g5c93766e) +85a0e3cbcec39c000d29002a9e9bce3150115ac2 server (v2023.5.0-35-g85a0e3cb)

Browser version

Chrome, Firefox

matthew-white commented 2 months ago

For v2023.5, we discussed making submission diffs and entity diffs more similar to each other. We didn't end up doing so because submission diffs are more complicated, as they involve repeat groups. That said, it should be easy to at least make empty values look the same in the two diffs.