search

getodk / central

ODK Central is a server that is easy to use, very fast, and stuffed with features that make data collection easier. Contribute and make the world a better place! ✨🗄✨
https://docs.getodk.org/central-intro/
Apache License 2.0
121 stars 145 forks source link

Manage Passwords dialog is shown when trying to download submissions from Encrypted Project #642

Open srujner opened 2 months ago

srujner commented 2 months ago

Problem description

Manage Passwords dialog is shown when trying to download submissions from Encrypted Project. Looks like stuff related with SSO. I'm not expecting this on the Chrome browser.

Steps to reproduce the problem

  1. Have encrypted project;
  2. Create a Draft with any form
  3. Navigate to the Testing tab
  4. Create at least one submission
  5. Click on the Download X Submission button

Expected behavior

There should be tooltip message, when no password is provided and no display window for Managing the accounts.

Central version shown in version.txt

9a9ec7c034de07e990c9c408ca768326e2154c96 (v2023.5.1-10-g9a9ec7c) +c25bc15087ca045496d3bdbc806ca0752b955216 client (v2023.5.0-64-gc25bc150) +cfe46c97e6e38d8e551ce253ba47d0b378d19352 server (v2023.5.0-56-gcfe46c97)

Browser Firefox

Other info screen-recorder-thu-apr-25-2024-13-58-19.webm

matthew-white commented 2 months ago

@srujner, this sounds like the same issue as #451. Does that sound right? Thank you for sharing the screen recording, that's very helpful. I'm not totally sure when we'll fix the issue, but I can see that it's annoying behavior.

Looks like stuff related with SSO.

My current thinking is that this will happen whenever you have an encrypted project and have to fill in the passphrase. I think Chrome sees the password field and tries to be helpful and autofill it with one of your saved passwords. And then once the field has been filled, it tries to be helpful again and update your saved passwords. I think we need to find some way to tell Chrome not to try to autofill the field.

matthew-white commented 2 months ago

this sounds like the same issue as #451

OK, now I'm seeing that there are some differences: #451 happened in Firefox, while this one happened in Chrome. Also, this one happens when you click a download button without filling in the passphrase field first. I'm hoping that it will be the same fix for both of them.