Form draft appears among linked forms

[matthew-white]

Problem description

In the entity list overview, we show the number of forms that use the entity list. Right now, that number includes forms where no published version of the form uses the entity list, but the form draft does.

URL of the page

https://staging.getodk.cloud/#/projects/88/entity-lists/trees

Steps to reproduce the problem

• Upload a form that uses a data file (e.g., trees.csv).
• Upload a .csv file for the data form attachment.
• Publish the form.
• Upload and publish a form that creates an entity list that matches the data file (e.g., named "trees").
• Create a draft of the first form.
• Link the data form attachment to the entity list, but don't publish the draft.
• Navigate to the entity list overview. Observe that the first form is listed as a form that uses the entity list.

Expected behavior

Form drafts should be excluded when determining the forms that use an entity list.

Central version shown in version.txt

versions:
9a9ec7c034de07e990c9c408ca768326e2154c96 (v2023.5.1-10-g9a9ec7c)
+3a9a6f02d49695e6216a30efe6c59a9cdea4c777 client (v2023.5.0-61-g3a9a6f02)
+44206801437e07ef52ac4ab1376bc5d0f4ff77d6 server (v2023.5.0-58-g44206801)

[matthew-white]

I added a new form to the project ("Tree registration 2") where the published version of the form doesn't modify entities, but the draft version does. The form isn't shown on the entity list overview, either under "Connection to Forms" (as part of the number of forms that update Entities) or under "Entity Properties" (in the "Updated by" column). In other words, I think there's some inconsistency around when we surface a form draft.