Followup S3 blob work - Githubissues

getodk / central

ODK Central is a server that is easy to use, very fast, and stuffed with features that make data collection easier. Contribute and make the world a better place! ✨🗄✨

https://docs.getodk.org/central-intro/

Apache License 2.0

126 stars 155 forks source link

Followup S3 blob work #700

Closed ktuite closed 1 month ago

ktuite commented 2 months ago

Followup to issue https://github.com/getodk/central/issues/585 after merging PR https://github.com/getodk/central-backend/pull/1071

Must have:

To consider:

[x] Move pgrowlocks requirement to tests https://github.com/getodk/central-backend/pull/1190
[x] logging events? upload succeed, upload failed etc.? make an audit log event from nightly processing job
[x] should migrating back from s3 to postgres be supported?
- "Once you opt into using S3-compatible storage, you can't opt back out of it and migrate files back to the database." (getodk/docs#1859)

For after .2:

nginx config to mask URLs: https://github.com/getodk/central/issues/716

Noting ideas/questions that came up but that we will park for now:

tests for missing blobs, e.g. a single missing blob in a data export?
are there race conditions in purge code? purge vs blobs re-attaching?