getodk / collect

ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨
https://docs.getodk.org/collect-intro
Other
718 stars 1.38k forks source link

Problems with Range Widgets with RTL languages #1983

Closed mmarciniak90 closed 6 years ago

mmarciniak90 commented 6 years ago

Software and hardware versions

Collect v1.13.2

Problem description

Problems with Range Widgets with RTL languages

Steps to reproduce the problem

  1. User uses RTL languages
  2. User opens Range widget
  3. Horizontal widget shows incorrect value on Android 4.4 (Vertical widget works as expected)
Integer Decimal
screenshot_2018-03-07-13-19-56 screenshot_2018-03-07-13-20-29
  1. Vertical widget shows incorrect value on Android 5.1, 6.0, 7.0, 8.0
Integer Decimal
screenshot_20180307-164121 screenshot_20180307-183643
  1. Vertical widget is not centred on Android 4.2 and values are incorrect
  2. Min and max values are overlapped in horizontal widget on Android 4.2
screenshot_2018-03-07-13-37-41 screenshot_2018-03-07-13-38-02 screenshot_2018-03-07-13-37-56 screenshot_2018-03-07-13-37-50

Expected behavior

Hanan194 commented 6 years ago

Hello, I want to take this task , will start working on it and show my progress as soon as possible

Hanan194 commented 6 years ago

@opendatakit-bot claim

getodk-bot commented 6 years ago

Welcome to Open Data Kit, @Hanan194! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

See you on the other side (that is, the pull request side)!

getodk-bot commented 6 years ago

Hello @Hanan194, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 10 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

huangyz0918 commented 6 years ago

@opendatakit-bot claim

huangyz0918 commented 6 years ago

@opendatakit-bot unclaim

huangyz0918 commented 6 years ago

This is a widget full of issues :( Tested Device: Samsung Galaxy S8, Android 7.0

Problems: Vertical widgets show an incorrect value, and the blue line used to highlight disappeared.

Integer Decimal

Horizontal widget works well. This is a problem associated with RTL language, I'm currently working on issue#1981, which is also a RTL problem, I think I can address both of them if they came from similar reason. If anyone would like to collaborate with me on these two issues, I would be very happy :>

mmarciniak90 commented 6 years ago

@huangyz0918 The problem with blue line looks more like https://github.com/opendatakit/collect/issues/1262. Incorrect value is mentioned in point 4 of the problem description. The behaviour of Range Widgets depends on Android version.

jingege315 commented 6 years ago

@opendatakit-bot claim

getodk-bot commented 6 years ago

Welcome to Open Data Kit, @jingege315! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

See you on the other side (that is, the pull request side)!

jingege315 commented 6 years ago

@opendatakit-bot unclaim

huangyz0918 commented 6 years ago

@opendatakit-bot claim