getodk / collect

ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨
https://docs.getodk.org/collect-intro
Other
718 stars 1.38k forks source link

Log Google Analytics event for protocol on server URL change #2516

Closed lognaturel closed 6 years ago

lognaturel commented 6 years ago

ODK Central is designed to be secure out of the box. As options for supporting HTTP or not are being considered, it would be helpful to know what the ratio of HTTP to HTTPS servers used with Collect is.

Changes to the server URL go through ServerPreferencesFragment.createChangeListener. If the URL is valid, an analytics event should be logged with category "SetServer" and an action of either "HTTP" or "HTTPS" depending on the prefix of the URL (case insensitive).

Additionally, we would like to know what servers are the same without compromising user privacy. To do this, we can log a hash of the full URL. See WidgetFactory for a similar example.

nexusbr commented 6 years ago

@opendatakit-bot claim

getodk-bot commented 6 years ago

Welcome to Open Data Kit, @nexusbr! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

See you on the other side (that is, the pull request side)!

getodk-bot commented 6 years ago

Hello @nexusbr, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 5 days.

If you've decided to work on something else, simply comment @opendatakit-bot unclaim so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Open Data Kit!