search

getodk / collect

ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨
https://docs.getodk.org/collect-intro
Other
715 stars 1.37k forks source link

Investigate max zoom levels for maps #5242

Closed seadowg closed 1 year ago

seadowg commented 2 years ago

As per this forum post, it seems like the max zoom level for Mapbox has been reduced in Collect v2022.3. We should investigate whether we can get back to the zoom levels that were possible in v2022.2. Additionally, it would be good to look into whether we can unlock those kinds of zoom levels in OSM/Google.

grzesiek2010 commented 2 years ago

Mapbox provides maps in 23 zoom levels, with 0 being the lowest zoom level (fully zoomed out) and 22 being the highest (fully zoomed in).

https://docs.mapbox.com/help/glossary/zoom-level/

I don't think we can change it but let's take a look...

grzesiek2010 commented 2 years ago

Ok I've checked it and this is now only possible with OSM, but also not too much because otherwise it might throw exceptions like java.lang.IllegalArgumentException: MapTileIndex: Zoom (30) is too big (zoom=30). Should we do that for this provider I'm not sure? What do you think @seadowg @lognaturel?

seadowg commented 2 years ago

Ok I've checked it and this is now only possible with OSM,

So we're already supporting the max possible zoom levels for Google Maps and Mapbox right?

it might throw exceptions like java.lang.IllegalArgumentException: MapTileIndex: Zoom (30) is too big (zoom=30). Should we do that for this provider I'm not sure?

Are you saying we could add extra zoom levels for OSM but need to limit it to 30?

grzesiek2010 commented 2 years ago

So we're already supporting the max possible zoom levels for Google Maps and Mapbox right?

Yes

Are you saying we could add extra zoom levels for OSM but need to limit it to 30?

I'm not sure what value is the last supported one, I've just got that exception testing 30 probably something lower would work fine but I would need to test more.

seadowg commented 1 year ago

I've filed an issue with Mapbox https://github.com/mapbox/mapbox-maps-android/issues/1802.