getodk / collect

ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨
https://docs.getodk.org/collect-intro
Other
718 stars 1.38k forks source link

Shortcuts- multiple issues #5292

Open dbemke opened 2 years ago

dbemke commented 2 years ago

ODK Collect version

Reproducible both on Master and Store Version (2022.3.5) Android version

Android 8.1, 11, 13 (on the emulator) Device used

Nexus 5X, Samsung Galaxy M12, emulator with android 13

Problem description

Switching between forms from shortcuts at least two times results in opening a wrong form.

Steps to reproduce the problem

1. Create a shortcut for All widgets and any other form.
2. Open the second form from the shortcut.
3. Minimize the app and go to the home screen.
4. Open to All widgets form from the shortcut.
5. Minimize the app and go to the home screen.
6. Go to the second form from the shortcut.

All widgets form is opened instead of the second form.

Expected behavior

Tapping on a form from a shortcut opens the form which the user intended to open.

dbemke commented 2 years ago

ODK Collect version

Master Android version

Android 8.1, 11, 13 (on the emulator) Device used

Nexus 5X, Samsung Galaxy M12, emulator with android 13

Problem description

Form media files missing when the user switches between forms from shortcuts.

Steps to reproduce the problem

  1. Create shortcuts for Birds form and All widgets form.
  2. Start filling Birds form from the shortcut.
  3. Minimize the form and go to the home screen.
  4. Go to All widgets form.
  5. Go to the end and save the form.
  6. When the Birds form opens go to the question "What bird did you see?”.

Expected behavior

When a form with media files is reopened from a shortcut no media should be missing. The form media files should be included as it was in the first opening of the form from the shortcut.

Other information

If the user minimizes the Birds form while being on the "What bird did you see” question, the issue of missing files doesn’t occur. On the play store version (v2022.3.5) the user is unable to reproduce step 6, because in this version it isn't possible to swipe to the following questions.

dbemke commented 2 years ago

Birds form and media Birds.xml.txt drive-download-20220609T092138Z-001.zip.txt

dbemke commented 2 years ago

ODK Collect version

Reproducible both on Master and Store Version (2022.3.5) Android version

Android 8.1, 11, 13 (on the emulator) Device used

Nexus 5X, Samsung Galaxy M12, emulator with android 13

Problem description

After opening a form with background audio recording and then opening All widgets form from a shortcut background audio recording appears in All widgets form and crashes the app.

Steps to reproduce the problem

1. Create a demo project in Collect.
2. Create a shortcut for All widgets form.
3. Go to Background audio recording form (in Collect or shortcut of the form).
4. Allow audio recording.
5. Minimize the app and go to home screen.
6. Open All widgets form from the shortcut.
7. Tap stop audio recording button.

Expected behavior

Background audio recording shouldn’t appear in All widgets form.

Other information

In Collect v2021.3.4, v2022.1.0 after reproducing those steps the background audio recording is visible in All widgets but the user can see an error dialog.

srujner commented 2 years ago

ODK Collect version Reproducible both on Master and Store Version (2022.3.5)

Android version Android 12 and 13 (on emulator)

Device used Google Pixel 3a and Emulator with Android 13

Problem description

After adding a new form to the current list, it will not be sorted alphabetically when creating a shortcut

Steps to reproduce the problem

  1. Scan a project from Central in Collect.
  2. Add new xml form to Central.
  3. Allow Form Access on Central to newly added form.
  4. Hold ODK app to Create a shortcut on desktop.
  5. When the Select ODK Shortcut list will appear move to the bottom of that list.
  6. Newly added form won't be sorted alphabetically.

Screenshot_20220923-140900

Expected behavior

Newly added form should be sort alphabetically.

lognaturel commented 1 year ago

None of these are great but they also feel like states that could be identified in training and reported to us. It's possible no one makes use of shortcuts in a way that triggers these bad things.

Most of these do point to issues in the order things are initialized or what state is kept globally. I'd be particularly interested in addressing this one about media.