getodk / collect

ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨
https://docs.getodk.org/collect-intro
Other
713 stars 1.37k forks source link

Enable DeletingRepeatGroupsTest #6101

Closed grzesiek2010 closed 5 months ago

grzesiek2010 commented 5 months ago

Closes #6078

Why is this the best possible solution? Were any other approaches considered?

It seems something has changed because the tests in DeletingRepeatGroupsTest are now functioning well. I've run each test in that class 300 times on Firebase (150 on API 30 and 150 on API 34), and there hasn't been a single failure.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It doesn't require testing.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

seadowg commented 5 months ago

I've run each test in that class 300 times on Firebase (150 on API 30 and 150 on API 3), and there hasn't been a single failure.

Just to double check before merging: this should "150 on API 34" right?

grzesiek2010 commented 5 months ago

Just to double check before merging: this should "150 on API 34" right?

Yes.