search

getodk / collect

ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨
https://docs.getodk.org/collect-intro
Other
705 stars 1.36k forks source link

Properties without ID and title in geojson cause error when opening select from map form #6162

Open WKobus opened 1 month ago

WKobus commented 1 month ago

ODK Collect version

the store version 2024.1.3, the master version e94c1e771eeb864188bbd35b2e7f1748d23e7ae8

Android version

10, 14

Device used

Galaxy M23, Redmi 7

Problem description

Properties without ID and title in geojson cause error when opening select from map form

Steps to reproduce the problem

  1. In central upload s1FromMap form and Geojson without ID and Title in properties S1FromMap.xlsx.txt items.geojson.txt
  2. Go to collect > start new form
  3. Open s1FromMap form

Expected behavior

Form should open without error when properties in attached geojson do not have ID and title

Other information

XRecorder_31052024_134937

seadowg commented 1 month ago

@grzesiek2010 this is expected right? I think we need id/title to treat them as selects.

grzesiek2010 commented 1 month ago

Yeah I believe that id/title in geojson represents the same as name/label in the choices sheet and that's why it's required but I wanted to double check so when @WKobus asked me if he should file an issue I said yes. I will take a look at the code to be sure and probably close the issue.