getodk / collect

ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨
https://docs.getodk.org/collect-intro
Other
718 stars 1.38k forks source link

Creating a new version of a form in Collect by pasting another form with the same ID to forms folder #6441

Open dbemke opened 1 month ago

dbemke commented 1 month ago

ODK Collect version

the store version 2024.2.4, the master version cff7a1e9e2c535099db878ac90798b9425c80e3d

Android version

10, 14

Device used

Redmi 9T, Pixel 7a

Problem description

Is creating a new version of a form in Collect by pasting another form with the same id (of an existing form in the project) to forms folder the expected behavior? I compared 2 scenarios for these steps - I created a project in Central, downloaded it to Collect and then I just pasted a form to forms folder in Collect:

Steps to reproduce the problem

  1. Create a project with the form on Central and download the project to Collect. blob_test.xml.txt
  2. Copy the second version of the form and via e.g. File Manager paste it to Collect forms folder. blob_test2.xml.txt
  3. Open "Star new form”.
lognaturel commented 1 month ago

The different ID case feels expected — in match exactly mode we only show forms that come from the server. Do you see it in manual form update mode?

There does seem to be something not quite right about the same ID, different version case. I don’t think it needs action, though, because a user would really have to do something unusual to get there.

dbemke commented 1 month ago

Do you see it in manual form update mode?

After pasting manually a "new version" of a form I go to "Download form" (in manual update mode) and download again the version of the form from the server, in "Start new form" there's the second version (not the one from the server I tried to download again).