getodk / collect

ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨
https://docs.getodk.org/collect-intro
Other
718 stars 1.38k forks source link

Pulldata treats ".” and "_” as the same symbol in entity properties #6461

Closed dbemke closed 1 month ago

dbemke commented 1 month ago

ODK Collect version

the master version 5dad7f4dfd4f4952a9516d959b3ed10c33ca33b0

Android version

10, 14

Device used

Redmi 9T, Pixel 7a

Problem description

It seems that pulldata treats ".” and "_” as the same symbol in properties. Opening an entities update form (using pulldata) with properties "circumference_cm” and "circumference.cm” causes an error. errorPulldata

Steps to reproduce the problem

  1. Create a project with trees registration form with properties "circumference_cm” and "circumference.cm”, trees update pulldata form or use user "one” in https://staging.getodk.cloud/#/projects/101/app-users trees_update_pulldata.xlsx.txt
  2. Download the project and open trees update pulldata form.

    Expected behavior

    I'm not sure what's the expected behavior (e.g. OData also converts some punctuation marks to "_") but maybe in Collect it shouldn't ?

lognaturel commented 1 month ago

I believe that in the short term https://github.com/getodk/collect/pull/6451 will address this. Maybe you can check it again when merged?

dbemke commented 1 month ago

I believe that in the short term #6451 will address this. Maybe you can check it again when merged?

I checked it and in #6451 the issue occurs.

lognaturel commented 1 month ago

I think that may mean that the pulldata database is still being built in addition to the entities database even though it's not used. I'm somewhat surprised by this so we should probably see what's going on.

lognaturel commented 1 month ago

Closing in favor of the more general #6471