Block settings that restart the app when in form entry

seadowg commented 3 weeks ago

Closes #6482

I've also cleaned up a couple of cases in FormFillingActivity that would return to the main menu in rare states.

Why is this the best possible solution? Were any other approaches considered?

As discussed in the issue and elsewhere, we decided to go with blocking these settings during form entry for now as reworking locking would be better to after #5420.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The main things to check here are that the user is not able to access settings that reproduce the bug.

Before submitting this PR, please make sure you have:

[x] added or modified tests for any new or changed behavior
[x] run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
[x] added a comment above any new strings describing it for translators
[x] added any new strings with date formatting to DateFormatsTest
[x] verified that any code or assets from external sources are properly credited in comments and/or in the about file.
[x] verified that any new UI elements use theme colors. UI Components Style guidelines

dbemke commented 2 weeks ago

Should "project management" (in settings) also be blocked during form entry?

seadowg commented 2 weeks ago

Should "project management" (in settings) also be blocked during form entry?

Yes. Any settings that allow you to return to the main menu should. In project management you can reset the project, reconfigure with QR code etc which all return to the main menu.

WKobus commented 2 weeks ago

Tested with Success

Verified on device with Android 15

Verified cases:

Issues #6482 does not occur
Check on settings during form entry
Check on settings when not in form entry
Changing language in form by "Choose language" option
Changing theme/language in phone settings during form entry

dbemke commented 2 weeks ago

Tested with Success

Verified on device with Android 10

getodk / collect