getodk / collect

ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨
https://docs.getodk.org/collect-intro
Other
717 stars 1.38k forks source link

Don't require a label for Entity updates #6515

Closed grzesiek2010 closed 4 days ago

grzesiek2010 commented 1 week ago

Closes #6511

Why is this the best possible solution? Were any other approaches considered?

There’s nothing to discuss here, as no alternative solutions were considered.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Creating entities without labels should still not be possible, as before. However, when updating existing entities, if a label is missing or empty, the existing label should be retained.

Do we need any specific form for testing your changes? If so, please attach one.

I used: entities_update.xlsx entities_registration.xlsx

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

dbemke commented 3 days ago

Tested with Success!

Verified on a device with Android 10

Verified cases:

WKobus commented 3 days ago

Tested with Success!

Verified on a device with Android 15