Fix list names with special characters

seadowg commented 6 days ago

Why is this the best possible solution? Were any other approaches considered?

I've just opted to quote the list names. I think a good follow up would be to use a safer mechanism to build SQL queries. Sadly, there's very little support for building complex queries with dynamic table/column names in the Android SDK itself, and I also haven't seen much in the way of third party libraries. We might have to roll our own solution.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?.

Should just allow list names with special characters (like favourite-films). It'd be good to do a full sweep of both dataset and property names to check that anything that can be created on Central is supported by Collect.

Before submitting this PR, please make sure you have:

[x] added or modified tests for any new or changed behavior
[ ] run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
[x] added a comment above any new strings describing it for translators
[x] added any new strings with date formatting to DateFormatsTest
[x] verified that any code or assets from external sources are properly credited in comments and/or in the about file.
[x] verified that any new UI elements use theme colors. UI Components Style guidelines

WKobus commented 5 days ago

Tested with Success!

Verified on device with Android 15, 10

Verified cases:

Different combinations of special characters in entity lists name and properties
Upgrading from older version

srujner commented 5 days ago

Tested with Success!

Verified on device with Android 14

getodk / collect