alyblenkin
commented
5 hours ago Given we've had the educational dialog for quite some time, I think it's safe to remove it. Mostly because the pills are pretty intuitive and we haven't heard any feedback, that I'm aware of, about them causing confusion for data collectors.
Why is this the best possible solution? Were any other approaches considered?
Error/no errors pills were introduced in Oct 2023. It's fairly common for data collectors to switch devices or otherwise need to reinstall Collect. Seeing the education message again is not a very big deal but it is slightly annoying so I think now is a good time to remove it.
Happy to discuss and close this if others see a good reason to keep it in longer.
I considered keeping the "New feature" string but that would require using it somewhere to pass lint and I don't think it's worth it. I can bring back the translations if we need it again.
I used the translation editor to remove the string definition from all languages. This left the comments behind and those will be cleaned up the next time we update from Transifex.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The intentional change is to remove the information dialog. I think there is a low risk of a bug. The biggest risk is probably that someone who hasn't yet seen the pills doesn't see the information dialog and is confused about their function. I think they're pretty self-explanatory so this feels unlikely to me.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest