Updated PMD plugin to 6.20.0 - Githubissues

getodk / skunkworks-crow

Skunkworks-crow is an Android app for sharing filled forms stored in ODK Collect from one device to another

Other

23 stars 73 forks source link

Updated PMD plugin to 6.20.0 #336

Closed SaumiaSinghal closed 4 years ago

SaumiaSinghal commented 4 years ago

Closes #193

What has been done to verify that this works as intended?

I tested it by running ./gradlew pmd.

Why is this the best possible solution? Were any other approaches considered?

I updates the pmd version to the latest 6.20.0 and made minor changes to fix the pmd rule violations.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No risks

Before submitting this PR, please make sure you have:

[x] run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
[x] verified that any code or assets from external sources are properly credited in comments and/or in the about file.

ajay-prabhakar commented 4 years ago

@lakshyagupta21 the commits which we made before the putting PR for that circle CI build is not running, if we put the commit after putting the PR then only circle CI build got activated and then it is showing results But actually travis will do is when we put the PR it will check the last commit, for doing like that did we have to configure anything