search

getodk / validate

ODK Validate is a Java application for confirming that a form is valid and compliant with the ODK XForms specification. Contribute and make the world a better place! ✨🔍✨
https://docs.getodk.org/validate/
Other
9 stars 27 forks source link

Upgrade JavaRosa #44

Closed yanokwa closed 6 years ago

yanokwa commented 6 years ago

What has been done to verify that this works as intended?

I ran it and made tested a sample form.

Why is this the best possible solution? Were any other approaches considered?

There's pretty much only one way to upgrade this library.

Are there any risks to merging this code? If so, what are they?

Not really.

lognaturel commented 6 years ago

Did you try one that has new features like round-test.xml.txt That seems like a good sanity check.

yanokwa commented 6 years ago

That form you sent didn't work because of a parens issue. But this attached one works. round-test.xml.txt