search

getodk / validate

ODK Validate is a Java application for confirming that a form is valid and compliant with the ODK XForms specification. Contribute and make the world a better place! ✨🔍✨
https://docs.getodk.org/validate/
Other
9 stars 26 forks source link

Made ui look modern #53

Closed vigneshtdev closed 6 years ago

vigneshtdev commented 6 years ago

Closes #48

What has been done to verify that this works as intended?

The application took up the native system feel when ran on Ubuntu 16,04 & Windows 10.

Why is this the best possible solution? Were any other approaches considered?

There were minimal changes to the code. Other approaches can be doing a whole redesign from scratch.

Are there any risks to merging this code? If so, what are they?

Majority of the OS's are covered. However if supplier not listed in How to Set the Look and Feel it might cause the program to crash.

yanokwa commented 6 years ago

Please don't combine two unrelated fixes. Send in two PRs. One for the code of conduct and one for the UI. And on the UI, be sure you've run ./gradlew check and fixed all the problems.