search

getodk / validate

ODK Validate is a Java application for confirming that a form is valid and compliant with the ODK XForms specification. Contribute and make the world a better place! ✨🔍✨
https://docs.getodk.org/validate/
Other
9 stars 26 forks source link

UI of the validate application now feels modern #54

Closed vigneshtdev closed 6 years ago

vigneshtdev commented 6 years ago

Closes #48

What has been done to verify that this works as intended?

The application was ran on Ubuntu 16.04 & Windows 10. In both cases the theme of the application matched the OS it was running in. Apart from this ./gradlew check ran successfully.

Why is this the best possible solution? Were any other approaches considered?

WIth a single line of code, the application is able to adjust its appearance according to the operating system it's being run in.

Are there any risks to merging this code? If so, what are they?

The application runs smoothly on most OS's. However if not listed here How to Set the Look and Feel, it's expected that the application will crash.

getodk-bot commented 6 years ago

Hello @vettyvignesh, an Open Data Kit maintainer reviewed this pull request over 7 days ago, but you haven't updated your pull request since. Please take a look at the requested changes and update your pull request accordingly.

Thank you for your valuable contributions to Open Data Kit!