search

getodk / validate

ODK Validate is a Java application for confirming that a form is valid and compliant with the ODK XForms specification. Contribute and make the world a better place! ✨🔍✨
https://docs.getodk.org/validate/
Other
9 stars 26 forks source link

Update javarosa v2.12.1 #61

Closed ukanga closed 5 years ago

ukanga commented 5 years ago

What has been done to verify that this works as intended?

Running all http://github.com/xlsform/pyxform tests with the generated jar file, no failures were reported.

Why is this the best possible solution? Were any other approaches considered?

Tried using class org.javarosa.core.model.actions.Action but it cannot be instantiated.

Are there any risks to merging this code? If so, what are they?

Yes, Actions may not be validated any more. Should they be validated?

yanokwa commented 5 years ago

@ukanga Should I do a release of Validate?

ukanga commented 5 years ago

@yanokwa Please do. I want to do a release of pyxform this week and having this be part of it would be ideal.

yanokwa commented 5 years ago

Release is out at https://github.com/opendatakit/validate/releases/tag/v1.10.3.