getodk / validate

ODK Validate is a Java application for confirming that a form is valid and compliant with the ODK XForms specification. Contribute and make the world a better place! ✨🔍✨
https://docs.getodk.org/validate/
Other
9 stars 26 forks source link

Upgrade source compatibility and gradle #71

Closed yanokwa closed 5 years ago

yanokwa commented 5 years ago

What has been done to verify that this works as intended?

I confirmed that the build runs and that a working XForm validates properly.

Why is this the best possible solution? Were any other approaches considered?

For target/source compatibility=1.7, gradle reports that it's obselete. And as to the gradle upgrade, we have to do that at some point. Now is as good as time as any.

Are there any risks to merging this code? If so, what are they?

Maybe the sourceCompatibility affects some upstream tool in some way? Seems unlikely.