getodk / validate

ODK Validate is a Java application for confirming that a form is valid and compliant with the ODK XForms specification. Contribute and make the world a better place! ✨🔍✨
https://docs.getodk.org/validate/
Other
9 stars 26 forks source link

Load extension specific itemset #74

Closed yanokwa closed 5 years ago

yanokwa commented 5 years ago

Closes #73

Some concerns for a reviewer

What has been done to verify that this works as intended?

Passes tests

Why is this the best possible solution? Were any other approaches considered?

JavaRosa loads a different parser for the secondary instance based on if the src path contains file-csv. Unless we change this behavior in JR, loading extension specific itemsets is our only reasonable option.

Are there any risks to merging this code? If so, what are they?

Nothing really. Maybe we should change the behavior in JR? But that seems more risky to me.