getodk / validate

ODK Validate is a Java application for confirming that a form is valid and compliant with the ODK XForms specification. Contribute and make the world a better place! ✨🔍✨
https://docs.getodk.org/validate/
Other
9 stars 27 forks source link

Update to JavaRosa 3 #84

Closed lognaturel closed 4 years ago

lognaturel commented 4 years ago

What has been done to verify that this works as intended?

Ran and validated a form I knew to be good and a form I knew to be bad.

Why is this the best possible solution? Were any other approaches considered?

Routine upgrade, no alternative.

Are there any risks to merging this code? If so, what are they?

JR 3 does change the way that expressions are evaluated. There are no desired behavior changes but some bugs could lead to problems in form validation.