search

getodk / xforms-spec

The XForms-derived specification used in the ODK ecosystem. If you are interested in building a tool that is compliant with the forms rendered by ODK tools, this is the place to start. ✨⚒✨
https://getodk.github.io/xforms-spec/
30 stars 26 forks source link

Add odk-new-repeat event #241

Closed lognaturel closed 5 years ago

lognaturel commented 5 years ago

Closes #246

Based on the conversation at https://forum.opendatakit.org/t/xforms-spec-proposal-add-event-fired-when-new-repeat-instance-is-created/19616

Please let me know if it's feeling like too much detail. I tried to capture everything we discussed and leave as little ambiguity as possible. In particular, the contrasting with W3C XForms feels like useful context to me but it's not really necessary.

The example is not realistic -- why in the world would 2 above the user's age be a useful default? My goal is to show an expression and the evaluation context for value. If a reviewer thinks a more realistic example would help, I can think of something.

CC @tiritea

MartijnR commented 5 years ago

Thanks! This is very good. Sorry, I somehow missed the alert email for this PR.

lognaturel commented 5 years ago

Thank you! I addressed your feedback in a separate commit so the diff was clear but please squash. And do let me know if you see anything else worth improving.