getodk / xforms-spec

The XForms-derived specification used in the ODK ecosystem. If you are interested in building a tool that is compliant with the forms rendered by ODK tools, this is the place to start. ✨⚒✨
https://getodk.github.io/xforms-spec/
30 stars 26 forks source link

min() and max() comply with XPath 2.0, not XForms 1.0 #272

Closed MartijnR closed 4 years ago

MartijnR commented 4 years ago

As we accept multiple parameters.

https://github.com/getodk/xforms-spec/issues/233

https://github.com/getodk/javarosa/blob/be1c28ea13585a5c43e184132ddbb8abf47a4e42/src/main/java/org/javarosa/xpath/expr/XPathFuncExpr.java#L329

MartijnR commented 4 years ago

Since we have no XPath 2.0 functions (and the spec is a weird doc), I propose we refer to XPath 3.0 instead: https://www.w3.org/TR/xpath-functions-30/#func-min

MartijnR commented 4 years ago

pinging @tiritea in case this affects your app's implementation

tiritea commented 4 years ago

Ta. Presently I do whatever libxml2 does... :-)