Closed jaredallard closed 1 year ago
:tada: This PR is included in version 1.15.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
It does not seem like the --skip-namespace
flag actually got hooked up to anything. is that on purpose?
This PR contains a number of reliability and UX improvements for using localizer in a larger cluster.
ctx.Done()
which would silently stop the port-forward on ^C. This caused invalid "use of closed connection" logging that was confusing to the user but also possibly could end up in a port-forward not being fully stopped./etc/host
modifications, ip pool cleanups, and other shutdown functions properly finish instead of possibly being terminated midway through during normal shutdown.client-go
. We still need a fork, but thankfully our fork is a single line now so it's much more likely we can upstream the change we made (the other change was upstreamed a year ago by another user!)stderr
from the port-forwarder to the console with a colored prefix. This makes it easier to tell when a port-forward was busted but localizer didn't detect it (or if it did, why it failed!)kube-system
) and enabled the user to pass--skip-namespace
to provide more (helps #212).NodePort
andLoadBalancer
service overhead that some larger clusters may have.debug
level. Defaults toinfo
logging instead ofdebug
logging (pass--log-level debug
for that!)