search

getov / CharacterStatsClassic

WoW Classic Addon for displaying TBC-like character stats interface
10 stars 10 forks source link

[Improvement] Missing Warlock Crit Talent #37

Closed lorem-ipsum-dolor-sit closed 4 years ago

lorem-ipsum-dolor-sit commented 4 years ago

Maybe I missed it, but it looks like the Warlock Destruction crit talent is missing in the crit calculation.

https://classic.wowhead.com/spell=18130/devastation

getov commented 4 years ago

Yep, it's missing. I haven't thought of a good way to present the spells' specific stats like Destruction. Is "destruction" crit different from "shadow" crit or is it the same?

lorem-ipsum-dolor-sit commented 4 years ago

It is the same.

All spells with a cast time are destruction (and do damage). All spells with no cast time are affliction.

So devastation is shadow crit, cause dots can not crit.

getov commented 4 years ago

In that case it shouldn't be too hard to add it into the calculation for shadow crit.

getov commented 4 years ago

Added in the latest release (3.5.2)