search

getov / CharacterStatsClassic

WoW Classic Addon for displaying TBC-like character stats interface
10 stars 9 forks source link

Hunter Critical Strike #42

Open DustinChecketts opened 4 years ago

DustinChecketts commented 4 years ago

I believe something is amiss with your calculations of Hunter Critical Strike in the Ranged pane. I a modestly geared Hunter, and everything has seemed to be fine with your addon with my Hunter and several other of my characters. However, I recently picked up Mandokir's Sting from ZG, as a considered replacement for Blastershot Launcher on my Hunter.

Skipping to the details, when naked (NOTHING else equipped, no buffs, no quiver or ammo pouch) I equip my Blastershot launcher and my Critical Strike is calculated at 8.46%. I have 5% from talents (Lethal Shots, that isn't added in until a ranged weapon isn't equipped), but the weapon only provides 1% critical strike chance, not 3.46%. So I would expect this to be 6%.

Meanwhile, Mandokir's Sting has +11 Agility, which I would expect to translate to some small amount of Critical Strike chance (roughly 0.4% (rounded up to the nearest tenth of a percent) if 29 Agility is equal to 1% Critical Strike chance). Again, with NOTHING else equipped, your addon shows only 5% Critical Strike in the Ranged pane. I would expect this to read approximately 5.4%.

Unless there are some hidden attributes of each weapon that affects things, I'm very confused since removing your addon still shows some oddities with these weapons in particular. I'll have to find some other ranged weapons to further test.

getov commented 4 years ago

Thanks for the report. I am only showing what Blizzard functions return. But if I have time I can dig more into that. Sadly I don't have a hunter to test that particular case.

DustinChecketts commented 4 years ago

I'm going to do some more testing today. But to follow up with more information, I found that my Bow Weapon Skill was only at 225 vs 300 on my Guns and Crossbows, so I'm thinking that has something to do with it. I had a BWL raid last night, so I couldn't play with it much, but I'll look at it more closely today after reaching 300 Weapon Skill in bows and see if it still looks wrong.

Good to know that you're just returning what Blizzard functions show. Might shed some light on how I can better optimize my gear and not just trust anything I see that someone says is BiS. Appreciate Addon developers such as yourself! Keep it up!

getov commented 4 years ago

Yeah, usually weapon skill also increases crit as far as I know. Might have something to do with it.

DustinChecketts commented 4 years ago

So I think the Weapon Skill was the issue. Things now appear to add up. The one additional comment I'll make is the deceptiveness of the Damage: stat displayed. This simply displays the damage capable of the weapon and doesn't take into consideration the weapon speed, or DPS. You must hover over this stat to get the DPS. I strongly feel that the weapon DPS should be displayed initially, without a hover, in order to compare weapons more quickly and generally.

Personally, I think you could replace the Damage: stat with DPS. Alternatively, you could make it customizable with a click on the stat itself, rotating through the various Damage: details found when hovering.

Just some feedback to consider. Again, I appreciate addon developers and how they continue to make valuable data more readily available to players.