search

getpatchwork / patchwork

Patchwork is a web-based patch tracking system designed to facilitate the contribution and management of contributions to an open-source project.
http://jk.ozlabs.org/projects/patchwork/
GNU General Public License v2.0
273 stars 82 forks source link

Duplicate tags in downloaded mbox #219

Open stephenfin opened 5 years ago

stephenfin commented 5 years ago

If a comment duplicates tags like Signed-off-by, these are de-duplicated when downloading the mbox. For example

https://patchwork.ozlabs.org/patch/982444/mbox/

<snip>

Following example commands can be used to set the auto-lb params:
ovs-vsctl set open_vswitch . other_config:pmd-auto-lb="true"
ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-thresh="80"
ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-min-improvement="5"
ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-drop-check="true"

Co-authored-by: Rohith Basavaraja <rohith.basavaraja@gmail.com>

Signed-off-by: Nitin Katiyar <nitin.katiyar@ericsson.com>
Signed-off-by: Rohith Basavaraja <rohith.basavaraja@gmail.com>
---
 lib/dpif-netdev.c | 589
+++++++++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 561 insertions(+), 28 deletions(-)

<snip>
git-pw patch download 982444 > rfc1-auto-balance.patch
cat !$
<snip>

Following example commands can be used to set the auto-lb params:
ovs-vsctl set open_vswitch . other_config:pmd-auto-lb="true"
ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-thresh="80"
ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-min-improvement="5"
ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-drop-check="true"

Co-authored-by: Rohith Basavaraja <rohith.basavaraja@gmail.com>

Signed-off-by: Nitin Katiyar <nitin.katiyar@ericsson.com>
Signed-off-by: Rohith Basavaraja <rohith.basavaraja@gmail.com>
Signed-off-by: Nitin Katiyar <nitin.katiyar@ericsson.com>
Signed-off-by: Rohith Basavaraja <rohith.basavaraja@gmail.com>
Signed-off-by: Nitin Katiyar <nitin.katiyar@ericsson.com>
Signed-off-by: Rohith Basavaraja <rohith.basavaraja@gmail.com>
---
 lib/dpif-netdev.c | 589
+++++++++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 561 insertions(+), 28 deletions(-)

<snip>
pevik commented 5 years ago

Noticed it as well, would be good to fix it.

pevik commented 5 years ago

Proposed solution is described as part of #57 (fixes more than this, already partly implemented).

veruu commented 5 years ago

@pevik if you mean my tagging rework, the series are available https://patchwork.ozlabs.org/project/patchwork/list/?series=66057 and are waiting before the Patch and Submission tables are flattened to help with DB performance.