search

getpatchwork / patchwork

Patchwork is a web-based patch tracking system designed to facilitate the contribution and management of contributions to an open-source project.
http://jk.ozlabs.org/projects/patchwork/
GNU General Public License v2.0
276 stars 82 forks source link

Message-IDs with slashes in them breaks mbox download #518

Closed djdelorie closed 1 year ago

djdelorie commented 1 year ago

See https://patchwork.sourceware.org/project/glibc/patch/Y%252F5wFE+YCYJ%252Fyr0j@morell/ The Message-ID is Y/5wFE+YCYJ/yr0j@morell

The "mbox" button doesn't work, but the "series" button does

Patch download in the event API is also broken: https://patchwork.sourceware.org/api/1.3/series/17683/ (click on patch mbox tag) (it's the same mbox URL, just trying to be complete ;)

codonell commented 1 year ago

This impacts part of the upstream glibc workflow, but only the part that tries to fetch the individual patches and apply them e.g. Patch Apply Bots.

Upstream kernel noticed this too: https://people.kernel.org/monsieuricon/fix-your-mutt And it is impacting public-inbox.

codonell commented 1 year ago

If / is valid in a message-id then I think we should handle it correctly with escaping, otherwise we're going to be chasing developers to fix their installations.

stephenfin commented 1 year ago

I thought we'd fixed this in https://github.com/getpatchwork/patchwork/issues/433. Are you using that patch? Did we miss a route?

codonell commented 1 year ago

@stephenfin Thank you for catching that! @siddhesh Have we updated our instance on Sourceware.org?

siddhesh commented 1 year ago

Our instance already has that fix, so I suspect we missed a route.

stephenfin commented 1 year ago

~@siddhesh Did you ever get to the bottom of this?~

never mind, still an issue. I've posted a fix and will apply and backport shortly.

stephenfin commented 1 year ago

This is now fixed and included in v3.1.3.