Open andrepapoti opened 4 months ago
Sorry for the absurd delay getting to this: my free time for Patchwork is pretty much zero recently... :sweat_smile:
I've taken a look at this locally but have yet to go into depth on it. There are two obvious issues starting out though. Firstly, you need to do some serious work on the queries: I loaded up the patchwork archives (following the guide in our development docs and loading the series-list
page took over 7 seconds and ~3050 queries (:smile:). Secondly, the current iteration of the UI doesn't work and it scrolls past the edge of the screen. I would suggest the following changes:
Series Name
should be the first column and called Series
, as we do for patch list and Patch
Number of Patches
to Patches
Other changes:
/series/{series}
should be /project/{project}/series/{series}
to map with patches/project/patchwork/series-list/
should be /project/patchwork/series/
, and we should rename /project/patchwork/list/
to /project/patchwork/patches/
(with an alias in place).This is rather beefy PR so if you have the ability to do, I'd suggest submitting v2 via the mailing list if you have the ability/know-how to do so. That'll be easier for me to review. Feel free to stick to GitHub if you can't/aren't comfortable using the mailing list though :slightly_smiling_face:
@stephenfin I've completed the adjustments you specified and also added pagination to the series list, the page is displaying 100 series at once and It's making 7 requests per page. I've also made the adjustments for the table display and endpoint urls. I'll submit this patch via email as well but it may be interesting to keep the discussion on github since the PR is tacking issues that are registered on this repository.
Description
This PR adds a new series-list and series-detail view. Some projects can have hundreds of patches actives at once, by giving the user the ability to have an overview of all of the series makes knowing what's the current state of a project much more simple. Series-list also allows the user to apply changes to all of the patches of a determined series, making the management of them easier Added navigation within a series for the patch-detail view
Related