getpelican / feedgenerator

Standalone version of Django's feedgenerator module
BSD 3-Clause "New" or "Revised" License
52 stars 23 forks source link

fix double occurence of subtitle if description and subtitle are given. #31

Closed venthur closed 3 years ago

venthur commented 3 years ago

The fix is rather trivial, this time i added a rather lengthily test that tests all four possible combinations against the expected result.

closes: #30

justinmayer commented 3 years ago

Merged these changes manually. Many thanks to @venthur for the fix and test improvements. Thanks also to @avaris for reviewing! 😁

venthur commented 3 years ago

Speaking of testing, would you be open to a little refactoring towards pytest? I think that would make the test code a bit simpler. I'm thinking specifically of removing the unittestcases and replacing them with simple test_xxs methods. If the answer is yes, I could be working on that.