search

getpelican / pelican-plugins

Collection of plugins for the Pelican static site generator
Other
1.38k stars 853 forks source link

[Migration] filetime_from_hg #1315

Open vishwin opened 3 years ago

vishwin commented 3 years ago

I'd like to migrate this plugin out of this monorepo into the pelican-plugins org, to at the very least serve as a place for continued development and maintenance. I've already created a repo using the CookieCutter, with the history from here git-filter-branch(1)ed out plus a bugfix commit from me, ready to transfer into the org.

cc: @douardda

douardda commented 3 years ago

thanks, looks fine to me, do you need any help from me?

kdeldycke commented 3 years ago

@douardda I guess you were CCed because @vishwin identified you as the original author of the plugin.

Looking around I can't unseen the existence of filetime_from_git plugin. @vishwin : what's the effort to merge the two?

vishwin commented 3 years ago

My last comment, now deleted, misspoke as I read that as filetime_from_hg. filetime_from_git is a completely different implementation. This plugin is as simple/short as it is because we use python-hglib from the official Mercurial project, and merging with the other plugin would introduce unnecessary complexities, not least of juggling two different library imports. I also don't personally use the other plugin. Thus, there is no effort to merge the two.

My CC was more of asking the original author for some tacit approval.

douardda commented 3 years ago

I agree that merging both the plugins would make things unnecessarily complex, even if they share some code (obviously, since filetime_from_hg has been written from filetime_from_git, as I mentioned in the README file IIRC) .