search

getpelican / pelican-plugins

Collection of plugins for the Pelican static site generator
Other
1.38k stars 849 forks source link

[migration] representative_image #1390

Closed schtobia closed 1 year ago

schtobia commented 1 year ago

Hi all, I would like to help with the migration of representative_image. I've worked with a proof of concept that works so far, i.e. is installable via pip (only via git+https). Could you please help me how to proceed from here?

justinmayer commented 1 year ago

Absolutely! Thank you for offering to assist with this. There are a few steps I need to perform before proceeding, including setting up the new repository under the Pelican Plugins organization.

I'll let you know when we are ready to begin taking the next steps.

justinmayer commented 1 year ago

In the process of creating the new repository, I decided to rename the plugin to Featured Image. I took the initial steps to rename the various pieces and apply the structure from the Pelican Plugin Template repository. The pull request containing that work is here: https://github.com/pelican-plugins/featured-image/pull/1

@schtobia: I invited you to join that repository as a maintainer. It seems the tests do not currently pass, which I confirmed is also the case in the original monolithic repository, i.e., before making any of the aforementioned changes. Would you be so kind as to take a stab at fixing the tests? That would be super-helpful and get us well on the way to getting this plugin fully migrated. ✨

schtobia commented 1 year ago

will do.

schtobia commented 1 year ago

hmm, it seems, there is a problem I could use some help with.

It seems like the register() function is successfully connected on all_generators_finalized, but the registered function is never called, at least in the test environment.

Could you please give me some directions where to look further?

justinmayer commented 1 year ago

Many thanks for the assistance with migrating this plugin, Tobias! 🥇