search

getpelican / pelican

Static site generator that supports Markdown and reST syntax. Powered by Python.
https://getpelican.com
GNU Affero General Public License v3.0
12.58k stars 1.81k forks source link

test.pip should install tox #2138

Closed ssteinerx closed 7 years ago

ssteinerx commented 7 years ago

While getting set up for development, the first thing I do after I've got all the project requirements set up is to run tox to make sure that what I've checked out is passing all of its tests before I start work.

I do not, purposely, have tox (or anything else) installed in my global Python environment.

I tried this while setting up to work on Pelican: tox isn't installed as a requirement.

Maybe there's some reason I don't know that tox shouldn't be installed in the current virtualenv?

If not, it's a one-line fix to requirements/test.pip.

If it should be there, should I do a pull request or just add this one line to my work on child themes? I'm a big fan of "one thing per pull request" but this seems pretty minor...

ingwinlu commented 7 years ago

That behaviour is on purpose.

tox manages virtual environments, hence installing it with all the other 'requirements' does not make sense. Additionally we don't want to dictate what people should use to run their tests (you could also go and create a venv yourself and run tests like that).

ssteinerx commented 7 years ago

Ok, thanks.

I prefer to install everything in the virtual environment but I guess that's a personal preference.

Closing.