search

getporter / az-mixin

An Azure CLI mixin for Porter
https://getporter.org/mixins/az/
Apache License 2.0
0 stars 11 forks source link

pkg/az: inject porter user agent #39

Closed VinozzZ closed 2 years ago

VinozzZ commented 2 years ago

Signed-off-by: Yingrong Zhao yingrong.zhao@gmail.com

This PR injects both porter and az-mixin's user agent into environment variable AZURE_HTTP_USER_AGENT so we can track porter usage when on azure platform.

this PR will close #38

carolynvs commented 2 years ago

What I do when I have a PR that relies upon another is to update the PR that depends on unmerged changes and tweak the go.mod file so that it uses a replace statement pointing at my fork and branch. That lets the build run successfully and then just like you did here, call out that it depends upon another PR. Then when the PR to Porter merges, you can just update the go.mod and then merge.

Otherwise it's hard to get a review on the PR that depends upon another until the first merges because the build is failing.