search

getporter / helm2-mixin

Helm mixin for Porter
https://porter.sh/mixins/helm
Apache License 2.0
13 stars 7 forks source link

Remove single quotes from Kubernetes resource outputs #71

Closed vdice closed 4 years ago

vdice commented 4 years ago

Assuming the issue filed in https://github.com/deislabs/porter/issues/1210 is determined to be a bug we wish to fix, incorporate the same fix into this mixin.

Ref https://github.com/deislabs/porter/issues/1210

vdice commented 4 years ago

I think the preferred way to do this would be to refactor the applicable logic to consume the getOutput logic from pkg/kubernetes/kubernetes.go(in deislabs/porter), so that the logic can be maintained/updated from the same one location.

carolynvs commented 4 years ago

See https://github.com/getporter/porter/pull/1227/files#diff-ee3f112df3df9e8ec5f3f9f98618987fR97 for the final fix