search

getporter / helm2-mixin

Helm mixin for Porter
https://porter.sh/mixins/helm
Apache License 2.0
13 stars 7 forks source link

Rename mixin to helm2 #81

Closed carolynvs closed 2 years ago

carolynvs commented 3 years ago

Especially now that helm v2 is being deprecated, we should rename the mixin to make it clear which version it is for and disambiguate it from Mohamed's helm3 mixin. Once we have it renamed, let's update the mixins list to clearly call out both mixins.

carolynvs commented 3 years ago

@vdice @MChorfa Let me know if you think this is a good idea or not. I'd like to knock this out soon if we all agree, since helm 2 is ... ☠️

vdice commented 3 years ago

👍 From me. Good call.

MChorfa commented 3 years ago

I would agree, but this means people would change all theirs porter def? Especially old deployments. I would favor handling helm and helm2 naming to ease the transition and document depreciation. WDYT?

carolynvs commented 3 years ago

I am suggesting that we stop publishing this mixin as "helm" (leaving the old mixin available for people to download who had it scripted). But going forward we publish changes to this mixin as "helm2", and delist "helm" so that people just see "helm2" and "helm3" mixins when looking for available mixins.

Does that sound right?

MChorfa commented 3 years ago

Yes absolutely. It is a good plan 🙌

carolynvs commented 3 years ago

Great! I'll submit a PR today to rename the mixin and announce the change on our mailing list. After helm2 mixin is live, I'll remove the old one from our search listings so people will realize they should all be using yours now.