getporter / operator

The Porter Operator gives you a native, integrated experience for managing your bundles from Kubernetes. It is the recommended way to automate your bundle pipeline with support for GitOps.
https://porter.sh/operator
Apache License 2.0
31 stars 18 forks source link

Remove controller-runtime from api layer of porter operator #299

Closed troy0820 closed 9 months ago

troy0820 commented 9 months ago

What does this change

Removes controller-runtime from the api layer of this operator. This will allow people to import types for their own consumption.

What issue does it fix

Sprawl and version skew. Allows us to decouple this from the operator's controller's dependencies.

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (511384c) 68.85% compared to head (ac38511) 68.90%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #299 +/- ## ========================================== + Coverage 68.85% 68.90% +0.05% ========================================== Files 14 15 +1 Lines 2244 2248 +4 ========================================== + Hits 1545 1549 +4 Misses 548 548 Partials 151 151 ``` | [Flag](https://app.codecov.io/gh/getporter/operator/pull/299/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getporter) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/getporter/operator/pull/299/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getporter) | `68.90% <100.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getporter#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.