search

getporter / vscode-extension

Visual Studio Code tools and integration for Porter
https://getporter.org
Apache License 2.0
8 stars 6 forks source link

Installation browser #45

Closed itowlson closed 3 years ago

itowlson commented 3 years ago

This is a basic installation browser for VS Code. The UI is pretty crude and could do with significant gussification. However it provides a list of installations, which can be expanded to show history, and you can view installation outputs and action logs.

carolynvs commented 3 years ago

Screen Shot 2021-04-14 at 10 24 49 AM

Nice! I just had a couple questions:

  1. Does this leave room eventually to be able to browse credential and parameter sets? Eventually we will need a way to pick what the user wold like to see. I'm not sure if the current UI would just show them under a new heading below installations?
  2. I'm unsure if we want to show the claim/run id for each entry under an installation. In the CLI we provide that information so that you can run a subsequent command to see the logs for a particular run. But in the GUI, I'm not sure if the user really needs to see that info and it would save a lot of space. What do you think?
itowlson commented 3 years ago

Does this leave room eventually to be able to browse credential and parameter sets?

Yes. This PR creates a Porter "activity bar" which can host multiple views. Although this PR only creates the Installations view, I expect to add other views such as Credentials as the muse comes upon me.

I'm unsure if we want to show the claim/run id for each entry under an installation.

We can definitely hide that. A useful command in that case might be "Copy Claim ID" which would copy the claim ID to the clipboard so it could be pasted into the terminal when the user dropped down to the CLI. We should also consider if there are any scenarios where a user might have a claim ID from elsewhere (e.g. CI logs?) and want to find that claim in the GUI. But neither of these require us to put the claim ID right in the user's face.

itowlson commented 3 years ago

@carolynvs Thanks heaps for the feedback! I think everything is addressed now.

itowlson commented 3 years ago

@carolynvs Could you take another look at this please? If we can merge this then it unblocks doing the credential set and parameter set browsers. (This is not a promise to spring into action the moment this one is merged...)

itowlson commented 3 years ago

I don't think we can disable the logs command, only hide it, which might be puzzling. I agree, let's tackle this later and think about the least worst user experience!

carolynvs commented 3 years ago

Would you be up for releasing this as new version on the marketplace and we can write a blog post about the new features?