search

getredash / contrib-helm-chart

Community maintained Redash Helm Chart
Apache License 2.0
163 stars 143 forks source link

Update chart dependencies #144

Closed ArcticXWolf closed 8 months ago

ArcticXWolf commented 1 year ago

I have updated the postgresql and redis dependencies of this chart.

This introduced a breaking change for the postgresql credentials/secret:

  1. Helm values.yaml changes from postgresql.postgresqlUsername -> postgresql.auth.username
  2. Helm values.yaml changes from postgresql.postgresqlPassword -> postgresql.auth.password
  3. Helm values.yaml changes from postgresql.postgresqlDatabase -> postgresql.auth.database
  4. The key of the postgresql password secret changed from postgresql-password to password

So we need to do two things before merge and I would like to have your opinion on this:

  1. How do we deal and communicate the breaking changes?
  2. Update chart version number
masayuki038 commented 1 year ago

@grugnog I failed to launch Redash with this helm and added my comment to https://github.com/getredash/contrib-helm-chart/issues/145. Could you check this PR ?

masayuki038 commented 1 year ago

@grugnog ping

ArcticXWolf commented 1 year ago

[Copied from issue #145] @masayuki038 I dont see any further activity on this repo, so you probably have to fork and use my PR code to get it to work. Just as a headsup: if you want to use my PR, then you need to change your values.yaml keys a bit. I've detailed the changes in the PR description :) Hope it helps a bit!

masayuki038 commented 1 year ago

@justinclift Can you check this if you have some time?

justinclift commented 1 year ago

@masayuki038 I don't really have any clue with Helm, so can't directly help here.

That being said, it looks like @ArcticXWolf might be interested in helping out with this repo?

As in, potentially adding as a member to enable fixing/updating/etc stuff. @ArcticXWolf is that your kind of thing? :smile:

ArcticXWolf commented 1 year ago

Sorry, we only tested Redash for a short time and do not use it anymore. I just happened to fix this issue during experimentation. So sadly I wont have time to tend to this repo.

justinclift commented 1 year ago

@ArcticXWolf No worries. :smile:

AndrewChubatiuk commented 11 months ago

is it possible to become a maintainer of this repo?

justinclift commented 11 months ago

@AndrewChubatiuk it can be done, but the person will need to have a clear history of competency in the pieces involved. :smile:

AndrewChubatiuk commented 11 months ago

I would like to help with redash helm chart, but have no idea how do you measure competency

justinclift commented 11 months ago

Well, your GitHub profile seems to be completely private. So it's super hard to tell what you're into, what you're good at, look at how well you interact with others, and that kind of thing. :frowning:

AndrewChubatiuk commented 10 months ago

@justinclift my profile should be public now

justinclift commented 10 months ago

@AndrewChubatiuk Cool. Looking over some of your activity for the last several years, it looks legit rather than dodgy. So, no worries from me now. :smile:

justinclift commented 10 months ago

@grugnog Are you ok with @AndrewChubatiuk being added as a maintainer for this repo? :smile:

justinclift commented 10 months ago

@AndrewChubatiuk If we don't get a response in a few days, we can just go ahead and add you as a maintainer. :wink:

justinclift commented 10 months ago

@AndrewChubatiuk Heh Heh Heh, I nearly forgot about this.

As we've not heard anything from @grugnog, I've just sent you an invite for this repo so you can do stuff in it. :smile:

AndrewChubatiuk commented 9 months ago

@justinclift could you please provide me more access in a repo? I want to replace circleci with github actions

AndrewChubatiuk commented 8 months ago

closing this PR as it's covered in #158

justinclift commented 8 months ago

could you please provide me more access in a repo?

@AndrewChubatiuk Oops, I missed that message. Is this something you still need me to look into?