search

getredash / redash-toolbelt

API client and utilities to manage a Redash instance
BSD 2-Clause "Simplified" License
140 stars 74 forks source link

Update redash-migrate README with details about data source migration. #89

Closed susodapop closed 3 years ago

susodapop commented 3 years ago

Description

Two changes in this PR:

  1. Update the README with details about the data_sources command
  2. Rename data_sources to data-sources so it will be consistent with other CLI tools.
# before
redash-migrate data_sources

# after
redash-migrate data-sources

Related Tickets & Documents

Resolves confusion around #86

susodapop commented 3 years ago

@wtfzambo @yu-iskw would appreciate your eyes on this in case I missed something obvious 👀

restyled-io[bot] commented 3 years ago

Hey there-

I'm a bot, here to let you know that some code in this PR might not match the team's automated styling. I ran the team's auto-reformatting tools on the files changed in this PR and found some differences. Those differences can be seen in #90.

Please see that Pull Request's description for more details.

justinclift commented 3 years ago

Heh Heh Heh. That restyled-io bot is such a pita. Case in point: https://github.com/getredash/setup/pulls

wtfzambo commented 3 years ago

@susodapop at this point I would also rename check_data_sources to check-data-sources for consistency.

Edit: as well as disable-users

susodapop commented 3 years ago

Done @wtfzambo. Look good?

wtfzambo commented 3 years ago

LGTM!

susodapop commented 3 years ago

Awesome! @wtfzambo I added you to this repo so you can actually grant approving reviews 👍

wtfzambo commented 3 years ago

@susodapop what a big responsibility you bestow upon me! 🥇🥇🥇