15 syntax errors

[cclauss]

flake8 testing of https://github.com/getredash/redash on Python 3.7.0

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./redash/models.py:272:32: F821 undefined name 'basestring'
        if isinstance(api_key, basestring):
                               ^
./redash/models.py:414:16: F821 undefined name 'unicode'
        return unicode(self.id)
               ^
./redash/models.py:1104:16: F821 undefined name 'unicode'
        return unicode(self.id)
               ^
./redash/query_runner/memsql_ds.py:142:36: E999 SyntaxError: invalid syntax
            raise sys.exc_info()[1], None, sys.exc_info()[2]
                                   ^
./redash/query_runner/mssql_odbc.py:156:36: E999 SyntaxError: invalid syntax
            raise sys.exc_info()[1], None, sys.exc_info()[2]
                                   ^
./redash/query_runner/script.py:86:36: E999 SyntaxError: invalid syntax
            raise sys.exc_info()[1], None, sys.exc_info()[2]
                                   ^
./redash/query_runner/axibase_tsd.py:176:36: E999 SyntaxError: invalid syntax
            raise sys.exc_info()[1], None, sys.exc_info()[2]
                                   ^
./redash/query_runner/hive_ds.py:90:36: E999 SyntaxError: invalid syntax
            raise sys.exc_info()[1], None, sys.exc_info()[2]
                                   ^
./redash/query_runner/elasticsearch.py:378:36: E999 SyntaxError: invalid syntax
            raise sys.exc_info()[1], None, sys.exc_info()[2]
                                   ^
./redash/query_runner/mssql.py:174:36: E999 SyntaxError: invalid syntax
            raise sys.exc_info()[1], None, sys.exc_info()[2]
                                   ^
./redash/query_runner/pg.py:149:43: E999 SyntaxError: invalid syntax
                                      async=True)
                                          ^
./redash/query_runner/query_results.py:33:8: F821 undefined name 'unicode'
    if unicode(value).lower() in ('true', 'false'):
       ^
./redash/query_runner/sqlite.py:90:30: E999 SyntaxError: invalid syntax
            raise unicode_err, None, sys.exc_info()[2]
                             ^
./redash/query_runner/vertica.py:142:36: E999 SyntaxError: invalid syntax
            raise sys.exc_info()[1], None, sys.exc_info()[2]
                                   ^
./redash/query_runner/dynamodb_sql.py:136:36: E999 SyntaxError: invalid syntax
            raise sys.exc_info()[1], None, sys.exc_info()[2]
                                   ^
./redash/query_runner/big_query.py:310:36: E999 SyntaxError: invalid syntax
            raise sys.exc_info()[1], None, sys.exc_info()[2]
                                   ^
./redash/cli/data_sources.py:105:23: F821 undefined name 'unicode'
            'string': unicode,
                      ^
./redash/cli/users.py:16:27: F821 undefined name 'basestring'
    if isinstance(groups, basestring):
                          ^
./redash/utils/__init__.py:137:29: F821 undefined name 'unicode'
        if isinstance(val, (unicode, str)):
                            ^
./redash/settings/organization.py:5:33: E999 SyntaxError: invalid syntax
    print "DEPRECATION NOTICE:\n"
                                ^
./redash/tasks/queries.py:451:21: F821 undefined name 'unicode'
            error = unicode(e)
                    ^
./redash/handlers/data_sources.py:192:32: F821 undefined name 'unicode'
            return {"message": unicode(e), "ok": False}
                               ^
./migrations/versions/969126bd800f_.py:25:46: E999 SyntaxError: invalid syntax
    print "Updating dashboards position data:"
                                             ^
./old_migrations/0003_update_data_source_config.py:16:43: F821 undefined name 'basestring'
        if isinstance(configuration_json, basestring):
                                          ^
./bin/get_changes.py:35:20: E999 SyntaxError: invalid syntax
        print change                   ^
./tests/test_authentication.py:215:13: F821 undefined name 'reload'
            reload(settings)
            ^
./tests/test_authentication.py:219:33: F821 undefined name 'reload'
        self.addCleanup(lambda: reload(settings))
                                ^
15    E999 SyntaxError: invalid syntax
12    F821 undefined name 'basestring'
27

[arikfr]

We can close this following your pull request, right?

[cclauss]

Good catch. I added an appropriate "Fixes" label to the PR.