getredash / redash

Make Your Company Data Driven. Connect to any data source, easily visualize, dashboard and share your data.
http://redash.io/
BSD 2-Clause "Simplified" License
26.16k stars 4.36k forks source link

docker-compose up fails because of outdated and conflicting requirements #5589

Closed frafra closed 11 months ago

frafra commented 3 years ago

That would solve all the dependencies issues, but dql seems to have a bug:

server_1     |   File "/usr/local/lib/python3.7/site-packages/dql/__init__.py", line 6, in <module>
server_1     |     from .cli import DQLClient
server_1     |   File "/usr/local/lib/python3.7/site-packages/dql/cli.py", line 21, in <module>
server_1     |     from .engine import FragmentEngine
server_1     |   File "/usr/local/lib/python3.7/site-packages/dql/engine.py", line 47, in <module>
server_1     |     from .grammar import line_parser, parser
server_1     |   File "/usr/local/lib/python3.7/site-packages/dql/grammar/__init__.py", line 37, in <module>
server_1     |     from .query import (
server_1     |   File "/usr/local/lib/python3.7/site-packages/dql/grammar/query.py", line 45, in <module>
server_1     |     from .parsed_primitives import primitive as parsed_primitive
server_1     |   File "/usr/local/lib/python3.7/site-packages/dql/grammar/parsed_primitives.py", line 30, in <module>
server_1     |     integer = pyparsing_common.signedInteger
server_1     | AttributeError: type object 'pyparsing_common' has no attribute 'signedInteger'

So I just disabled dql.

It would be good to integrate such docker build into the CI system, as these dependencies are not checked at the moment and are quite outdated.

susodapop commented 3 years ago

Thanks for bringing this to our attention. I will put eyes on this after the V10 release (shortly).

warwickchapman commented 3 years ago

Can I add to this by pointing out that mysqlclient urgently needs to be updated because it is not compatible with the default password encryption scheme of most versions of MySQL 8.0 including current.

susodapop commented 3 years ago

@warwickchapman IIRC this was fixed almost 18 months ago on master. What version are you running that still has this issue?

warwickchapman commented 3 years ago

I’m running 8.

I tried to upgrade to 10 and everything exploded.

I’ll try it again sometime and share details.

On Wednesday, September 29, 2021, Jesse @.***> wrote:

@warwickchapman https://github.com/warwickchapman IIRC this was fixed almost 18 months ago on master. What version are you running that still has this issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/getredash/redash/issues/5589#issuecomment-930225542, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNZ6UPGFMOGPDXY4ZCRHPLUEMOKNANCNFSM5D6AS6TA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Warwick Bruce Chapman | +27 83 7797 094 | http://wa.rwick.com

warwickchapman commented 3 years ago

@warwickchapman IIRC this was fixed almost 18 months ago on master. What version are you running that still has this issue?

Actually, when I reinstalled 8 after 10 blew up, I noted that mysqclient was only 1.4.4. I tried manually upgrading memsql to 3.1.0 and mysqlclient to 1.4.6 on each container but the issue remained - the one complaining about the missing mariadb library. It seems that issue is not related to mysqlclient version unless there is another I missed. When I change the hashing method for that user on the DB, I was able to connect fine.

guidopetri commented 11 months ago

With our new poetry setup, I believe any conflicting package issues are resolved. Closing, but feel free to reopen if you've still got issues with the preview image on dockerhub.