search

getredash / redash

Make Your Company Data Driven. Connect to any data source, easily visualize, dashboard and share your data.
http://redash.io/
BSD 2-Clause "Simplified" License
26.45k stars 4.38k forks source link

Automatically remove orphans when running make up #7164

Closed justinclift closed 2 months ago

justinclift commented 2 months ago

What type of PR is this?

Description

This is just a trivial quality of life improvement PR for Redash developers.

It adds the --remove-orphans option to the make up docker compose commands, to automatically remove orphaned containers from previous runs.

Without this option make up will commonly display a warning about orphaned containers:

WARN[0000] Found orphan containers ([redash-server-run-9d298b8fca7f]) for this project. If you
removed or renamed this service in your compose file, you can run this command with the
--remove-orphans flag to clean it up.

How is this tested?

Seems to work fine in my local development environment, and doesn't change any of our build nor running code. In theory (!), this shouldn't cause any issues.

justinclift commented 2 months ago

Oh yeah, good point. I guess we'll rediscover this then. :smile: